Expose retained memory estimates - #1174
Open
mjackson wants to merge 1 commit into
Open
Conversation
Expose allocator-independent URL and URLSearchParams capacity estimates through both the C++ and C APIs, with saturating arithmetic and growth coverage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
+ Coverage 59.79% 59.94% +0.15%
==========================================
Files 37 38 +1
Lines 6121 6149 +28
Branches 2978 2982 +4
==========================================
+ Hits 3660 3686 +26
Misses 618 618
- Partials 1843 1845 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@mjackson What is the purpose here? Will every little component of out software systems have a memory estimator bundled with it? What function does the estimator serve? How often are systems memory limited because they are storing too much data related to URLs? Are you going to be using this personally in a significant manner? Can you describe the usage you have in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url_aggregatorandurl_search_paramsThis lets embedders account for Ada-owned URL and query-list storage without inspecting private layout or allocating during GC.